refactor: suppress unnecessary null assertion in generated Kotlin files and update pbandk version [WPB-8645]#4158
Merged
MohamadJaara merged 1 commit intoMay 22, 2026
Conversation
…es and update pbandk version
MohamadJaara
requested review from
emmaoke-w,
ohassine,
saleniuk,
sbakhtiarov and
typfel
and removed request for
a team
|
Contributor
MohamadJaara
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4158 +/- ##
==========================================
Coverage 61.60% 61.60%
Complexity 4028 4028
==========================================
Files 2073 2073
Lines 67742 67742
Branches 6685 6685
==========================================
Hits 41735 41735
Misses 23346 23346
Partials 2661 2661 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
saleniuk
approved these changes
May 21, 2026
Contributor
Bencher Report
sbakhtiarov
approved these changes
May 22, 2026
MohamadJaara
deleted the
mo/refactor/supress-generated-proto-classes-null-assertion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-8645
the generated proto mapping classes have unnecessary null assertion with a wall of warnings